Messages in this thread | | | Subject | Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall | From | "Woodhouse, David" <> | Date | Wed, 10 Feb 2021 17:49:49 +0000 |
| |
On Wed, 2021-02-10 at 17:06 +0000, Julien Grall wrote: > From: Julien Grall <jgrall@amazon.com> > > After Commit 3499ba8198cad ("xen: Fix event channel callback via > INTX/GSI"), xenbus_probe() will be called too early on Arm. This will > recent to a guest hang during boot. > > If there hang wasn't there, we would have ended up to call > xenbus_probe() twice (the second time is in xenbus_probe_initcall()). > > We don't need to initialize xenbus_probe() early for Arm guest. > Therefore, the call in xen_guest_init() is now removed. > > After this change, there is no more external caller for xenbus_probe(). > So the function is turned to a static one. Interestingly there were two > prototypes for it. > > Fixes: 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI") > Reported-by: Ian Jackson <iwj@xenproject.org> > Signed-off-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk> Cc: stable@vger.kernel.org
Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.
| |