Messages in this thread | | | Subject | Re: [PATCH RFC v2 06/10] vdpa_sim: cleanup kiovs in vdpasim_free() | From | Jason Wang <> | Date | Mon, 1 Feb 2021 13:47:08 +0800 |
| |
On 2021/1/28 下午10:41, Stefano Garzarella wrote: > vringh_getdesc_iotlb() allocates memory to store the kvec, that > is freed with vringh_kiov_cleanup(). > > vringh_getdesc_iotlb() is able to reuse a kvec previously allocated, > so in order to avoid to allocate the kvec for each request, we are > not calling vringh_kiov_cleanup() when we finished to handle a > request, but we should call it when we free the entire device. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 53238989713d..a7aeb5d01c3e 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -562,8 +562,15 @@ static int vdpasim_dma_unmap(struct vdpa_device *vdpa, u64 iova, u64 size) > static void vdpasim_free(struct vdpa_device *vdpa) > { > struct vdpasim *vdpasim = vdpa_to_sim(vdpa); > + int i; > > cancel_work_sync(&vdpasim->work); > + > + for (i = 0; i < vdpasim->dev_attr.nvqs; i++) { > + vringh_kiov_cleanup(&vdpasim->vqs[i].out_iov); > + vringh_kiov_cleanup(&vdpasim->vqs[i].in_iov); > + } > + > put_iova_domain(&vdpasim->iova); > iova_cache_put(); > kvfree(vdpasim->buffer);
| |