Messages in this thread | | | From | Oleksandr Mazur <> | Subject | Re: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action | Date | Mon, 1 Feb 2021 14:54:55 +0000 |
| |
On Fri, 29 Jan 2021 11:15:43 +0000 Oleksandr Mazur wrote: > > >Thinking about it again - if the action can be changed wouldn't it > > >be best for the user to actually get a "HW condition hit" counter, > >> which would increment regardless of SW config (incl. policers)? > > > > >Otherwise if admin logs onto the box and temporarily enables a trap > >> for debug this count would disappear. >> >> But still this counter makes sense only for 'drop' action.
>Okay, well, "dropped while trap was disabled" seems a lot less useful >of a definition than "number of times this trap would trigger" but if >that's all the HW can provide then it is what it is.
>Does the HW also count packets dropped because of overload / overflow >or some other event, or purely dropped because disabled?
Hw starts counting traffic (hw drops) only when action has been explicitly set to be 'DROP';
| |