lkml.org 
[lkml]   [2021]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action
Date

On Fri, 29 Jan 2021 11:15:43 +0000 Oleksandr Mazur wrote:
> > >Thinking about it again - if the action can be changed wouldn't it
> > >be best for the user to actually get a "HW condition hit" counter,
> >> which would increment regardless of SW config (incl. policers)? 
> >
> > >Otherwise if admin logs onto the box and temporarily enables a trap
> >> for debug this count would disappear. 
>>
>> But still this counter makes sense only for 'drop' action.

>Okay, well, "dropped while trap was disabled" seems a lot less useful
>of a definition than "number of times this trap would trigger" but if
>that's all the HW can provide then it is what it is.

>Does the HW also count packets dropped because of overload / overflow
>or some other event, or purely dropped because disabled?

Hw starts counting traffic (hw drops) only when action has been explicitly set to be 'DROP';
\
 
 \ /
  Last update: 2021-02-01 16:17    [W:0.055 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site