Messages in this thread | | | Date | Mon, 1 Feb 2021 15:04:47 +0200 | From | Sakari Ailus <> | Subject | Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings |
| |
On Mon, Jan 18, 2021 at 02:55:07PM +0100, Paul Kocialkowski wrote: > Hi, > > On Sat 16 Jan 21, 21:11, Julia Lawall wrote: > > From: kernel test robot <lkp@intel.com> > > > > PTR_ERR should access the value just tested by IS_ERR > > Good catch! > > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Thanks, Julia and Paul.
A patch with similar content got recently merged:
commit 6e7cca2790a54057ddf64da7843271e192f71ca0 Author: Hans Verkuil <hverkuil-cisco@xs4all.nl> Date: Wed Jan 20 09:42:38 2021 +0100
media: i2c/ov8865.c: fix error checks using wrong variable
Fix two typos: dvdd -> dovdd and dvdd -> avdd
Both clearly copy-and-paste mistakes.
Fixes this smatch warning:
drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR'
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-- Kind regards,
Sakari Ailus
| |