Messages in this thread | | | Subject | Re: [PATCH v4 1/9] hugetlb: Pass vma into huge_pte_alloc() | From | Mike Kravetz <> | Date | Mon, 1 Feb 2021 13:38:50 -0800 |
| |
On 1/28/21 3:42 PM, Axel Rasmussen wrote: > From: Peter Xu <peterx@redhat.com> > > It is a preparation work to be able to behave differently in the per > architecture huge_pte_alloc() according to different VMA attributes. > > Signed-off-by: Peter Xu <peterx@redhat.com> > [axelrasmussen@google.com: fixed typo in arch/mips/mm/hugetlbpage.c] > Signed-off-by: Axel Rasmussen <axelrasmussen@google.com> > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > arch/ia64/mm/hugetlbpage.c | 3 ++- > arch/mips/mm/hugetlbpage.c | 4 ++-- > arch/parisc/mm/hugetlbpage.c | 2 +- > arch/powerpc/mm/hugetlbpage.c | 3 ++- > arch/s390/mm/hugetlbpage.c | 2 +- > arch/sh/mm/hugetlbpage.c | 2 +- > arch/sparc/mm/hugetlbpage.c | 2 +- > include/linux/hugetlb.h | 2 +- > mm/hugetlb.c | 6 +++--- > mm/userfaultfd.c | 2 +- > 11 files changed, 16 insertions(+), 14 deletions(-)
Sorry for the delay in reviewing.
huge_pmd_share() will do a find_vma() to get the vma. So, it would be 'possible' to not add an extra argument to huge_pmd_alloc() and simply do the uffd_disable_huge_pmd_share() check inside vma_shareable. This would reduce the amount of modified code, but would not be as efficient. I prefer passing the vma argument as is done here.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- Mike Kravetz
| |