Messages in this thread | | | Subject | Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved | From | Sergey Shtylyov <> | Date | Thu, 9 Dec 2021 20:24:59 +0300 |
| |
On 12/9/21 5:59 PM, Andy Shevchenko wrote:
> platform_get_irq() will print a message when it fails. > No need to repeat this. > > While at it, drop redundant check for 0 as platform_get_irq() spills > out a big WARN() in such case.
And? IRQ0 is still returned! :-(
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/ata/libahci_platform.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c > index 0910441321f7..1af642c84e7b 100644 > --- a/drivers/ata/libahci_platform.c > +++ b/drivers/ata/libahci_platform.c > @@ -579,13 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev, > int i, irq, n_ports, rc; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(dev, "no irq\n"); > + if (irq < 0) > return irq; > - } > - if (!irq) > - return -EINVAL;
This is prermature -- let's wait till my patch that stops returning IRQ0 from platform_get_irq() and friends gets merged....
MBR, Sergey
| |