Messages in this thread | | | Date | Thu, 9 Dec 2021 18:10:50 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH v14 2/4] dmaengine: tegra: Add tegra gpcdma driver |
| |
On Mon, Dec 06, 2021 at 06:30:37PM +0530, Akhil R wrote: > Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver > supports dma transfers between memory to memory, IO peripheral to memory > and memory to IO peripheral. > > Signed-off-by: Pavan Kunapuli <pkunapuli@nvidia.com> > Signed-off-by: Rajesh Gumasta <rgumasta@nvidia.com> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > Reviewed-by: Jon Hunter <jonathanh@nvidia.com> > --- > drivers/dma/Kconfig | 12 + > drivers/dma/Makefile | 1 + > drivers/dma/tegra186-gpc-dma.c | 1284 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1297 insertions(+) > create mode 100644 drivers/dma/tegra186-gpc-dma.c > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 80c2c03..35095ae 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -629,6 +629,18 @@ config TXX9_DMAC > Support the TXx9 SoC internal DMA controller. This can be > integrated in chips such as the Toshiba TX4927/38/39. > > +config TEGRA186_GPC_DMA > + tristate "NVIDIA Tegra GPC DMA support" > + depends on ARCH_TEGRA_186_SOC || ARCH_TEGRA_194_SOC || COMPILE_TEST
I wonder if we want to maybe make this depend on ARCH_TEGRA instead to avoid having to add dependencies on newer SoCs (presumably Tegra234 will feature this GPC DMA as well).
Not worth a respin, but perhaps something to consider when adding Tegra234 support.
Thierry [unhandled content-type:application/pgp-signature] | |