Messages in this thread | | | Date | Thu, 9 Dec 2021 09:40:18 -0600 | Subject | Re: [RFC v2 4/6] crash hp: generic crash hotplug support infrastructure | From | Eric DeVolder <> |
| |
On 12/8/21 07:38, David Hildenbrand wrote: >> +#if defined(CONFIG_MEMORY_HOTPLUG) >> +static int crash_memhp_notifier(struct notifier_block *nb, >> + unsigned long val, void *v) >> +{ >> + struct memory_notify *mhp = v; >> + unsigned long start, end; >> + >> + start = mhp->start_pfn << PAGE_SHIFT; >> + end = ((mhp->start_pfn + mhp->nr_pages) << PAGE_SHIFT) - 1; >> + >> + switch (val) { >> + case MEM_GOING_ONLINE: >> + crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY, >> + start, end-start); >> + break; >> + >> + case MEM_OFFLINE: >> + case MEM_CANCEL_ONLINE: >> + crash_hotplug_handler(KEXEC_CRASH_HP_REMOVE_MEMORY, >> + start, end-start); > > Any reason you don't handle this after the effects completely, meaning > MEM_ONLINE and MEM_OFFLINE? >
No, no reason. Great catch! I've changed it to use MEM_ONLINE/OFFLINE only. Thanks! eric
| |