lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt
    Date
    If 64-bit mask attempt fails, the 32-bit will fail by the very same reason.
    Don't even try the latter. It's a continuation of the changes that contains,
    e.g. dcc02c19cc06 ("sata_sil24: use dma_set_mask_and_coherent").

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/ata/libahci_platform.c | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
    index 1af642c84e7b..972f5ec86a27 100644
    --- a/drivers/ata/libahci_platform.c
    +++ b/drivers/ata/libahci_platform.c
    @@ -637,13 +637,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
    if (hpriv->cap & HOST_CAP_64) {
    rc = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
    if (rc) {
    - rc = dma_coerce_mask_and_coherent(dev,
    - DMA_BIT_MASK(32));
    - if (rc) {
    - dev_err(dev, "Failed to enable 64-bit DMA.\n");
    - return rc;
    - }
    - dev_warn(dev, "Enable 32-bit DMA instead of 64-bit.\n");
    + dev_err(dev, "Failed to enable 64-bit DMA.\n");
    + return rc;
    }
    }

    --
    2.33.0
    \
     
     \ /
      Last update: 2021-12-09 16:00    [W:4.772 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site