lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] sched/fair: avoid burst statistic if it's not set
On Wed, Dec 08, 2021 at 10:50:18PM +0800, Honglei Wang wrote:
> It's not necessary to do burst associated statistic and calculation for
> runtime if the burst feature is not set at all. Just return at the very
> start point if so.
>
> Signed-off-by: Honglei Wang <wanghonglei@didichuxing.com>
> ---
> kernel/sched/fair.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6e476f6d9435..2cd626c22912 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -4640,6 +4640,11 @@ void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b)
> if (unlikely(cfs_b->quota == RUNTIME_INF))
> return;
>
> + if (cfs_b->burst == 0 && cfs_b->runtime_snap == cfs_b->quota) {
> + cfs_b->runtime = cfs_b->quota;
> + return;
> + }
> +
> cfs_b->runtime += cfs_b->quota;
> runtime = cfs_b->runtime_snap - cfs_b->runtime;
> if (runtime > 0) {

What actual purpose does this patch serve, other than to increase the
line-count?

\
 
 \ /
  Last update: 2021-12-09 13:23    [W:0.038 / U:3.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site