lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 2/2] virtio-mem: prepare fake page onlining code for granularity smaller than MAX_ORDER - 1
From
Hi Eric,

thanks for the review!

>> if (PageDirty(page)) {
>> - virtio_mem_clear_fake_offline(pfn + i, max_nr_pages,
>> - false);
>> - generic_online_page(page, MAX_ORDER - 1);
>> + virtio_mem_clear_fake_offline(pfn + i, 1 << order, false);
>> + generic_online_page(page, order);
>> } else {
>> - virtio_mem_clear_fake_offline(pfn + i, max_nr_pages,
>> - true);
>> - free_contig_range(pfn + i, max_nr_pages);
>> - adjust_managed_page_count(page, max_nr_pages);
>> + virtio_mem_clear_fake_offline(pfn + i, 1 << order, true);
>> + free_contig_range(pfn + i, 1 << order);
>> + adjust_managed_page_count(page, 1 << order);
> In the loop, pfn + i, 1 << order are repeatedly calculated. 1 << order
> is a step size, pfn + i  is each step position.
> Better to figure the numer once each iter?

The compiler better be smart enough to calculate such constants once :)

>
> LGTL.
> LGTM.
> Reviewed-by: Eric Ren <renzhengeek@gmail.com>

Thanks!


--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2021-12-09 12:53    [W:0.043 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site