Messages in this thread | | | From | Alexandru M Stan <> | Date | Thu, 9 Dec 2021 14:49:57 -0800 | Subject | Re: [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node |
| |
On Thu, Dec 9, 2021 at 11:51 AM Prashant Malani <pmalani@chromium.org> wrote: > > Add a node describing the USB Type C connector, in order to utilize the > Chromium OS USB Type-C driver that enumerates Type-C ports and connected > cables/peripherals and makes them visible to userspace. > > Cc: Alexandru M Stan <amstan@chromium.org> > Cc: Benson Leung <bleung@chromium.org> > Signed-off-by: Prashant Malani <pmalani@chromium.org> > --- > > Changes in v2: > - Alexandru mentioned that HW specs suggest preferred power role for > devices like kukui to be sink, so changed try-power-role to "sink". > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index 94c13c459194..0f9480f91261 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -886,6 +886,20 @@ usbc_extcon: extcon0 { > cbas { > compatible = "google,cros-cbas"; > }; > + > + typec { > + compatible = "google,cros-ec-typec"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb_c0: connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "host"; > + try-power-role = "sink"; > + }; > + }; > }; > }; > > -- > 2.34.1.173.g76aa8bc2d0-goog >
Thanks!
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
| |