lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] clk: qcom: gcc-msm8974: Modernize the driver
From
Date
Hi Bjorn, thanks for the review!

> "xo_board" is actually the crystal feeding the PMIC with a reference
> clock, of interest here is that this is split up in the 2 digital and 3
> analog RPM_SMD_CX_{Dx,Ay} clocks. Out of these you have RPM_SMD_CXO_D0
> being wired up on the CXO pin on the msm8974.
>
> Back when this was devices we didn't have the means of dealing with
> rpmcc as parent to gcc, so you can in gcc_msm8974_probe() find the
> registration of a clock "xo" which is a 19.2MHz clock parented by
> "xo_board".
>
> As such, the appropriate .name here would be "xo".
>
> Likewise "xo" (or actually "cxo") would be a better name for the
> DT-based input clock - and it should point to &rpmcc RPM_SMD_CXO_D0
> (iiuc).

I'll try to fix the mentioned issue and send a v2 in series of patches
with other gcc-msm8974 improvements.

Regards,
Ivaylo

\
 
 \ /
  Last update: 2021-12-08 20:09    [W:0.065 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site