Messages in this thread Patch in this message | | | Date | Wed, 8 Dec 2021 13:43:04 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH -mm 4/5] tools/perf: replace hard-coded 16 with TASK_COMM_LEN |
| |
On Sat, 4 Dec 2021 09:52:55 +0000 Yafang Shao <laoar.shao@gmail.com> wrote:
> @@ -43,7 +45,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > return -1; > } > > - if (evsel__test_field(evsel, "prev_comm", 16, false)) > + if (evsel__test_field(evsel, "prev_comm", TASK_COMM_LEN, false)) > ret = -1; > > if (evsel__test_field(evsel, "prev_pid", 4, true)) > @@ -55,7 +57,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > if (evsel__test_field(evsel, "prev_state", sizeof(long), true)) > ret = -1; > > - if (evsel__test_field(evsel, "next_comm", 16, false)) > + if (evsel__test_field(evsel, "next_comm", TASK_COMM_LEN, false)) > ret = -1; > > if (evsel__test_field(evsel, "next_pid", 4, true)) > @@ -73,7 +75,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > return -1; > } > > - if (evsel__test_field(evsel, "comm", 16, false)) > + if (evsel__test_field(evsel, "comm", TASK_COMM_LEN, false))
Shouldn't all these be TASK_COMM_LEN_16?
-- Steve
> ret = -1; > > if (evsel__test_field(evsel, "pid", 4, true))
| |