| Date | Wed, 8 Dec 2021 11:58:16 -0400 | From | Jason Gunthorpe <> | Subject | Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data |
| |
On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote: > Store the properties which are interesting for various places so the MSI > descriptor fiddling can be removed. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > V2: Use the setter function > --- > drivers/pci/msi/msi.c | 8 ++++++++ > 1 file changed, 8 insertions(+)
I took more time to look at this, to summarize my remarks on the other patches
I think we don't need properties. The info in the msi_desc can come from the pci_dev which we have easy access to. This seems overall clearer
The notable one is the sysfs, but that is probably better handled by storing a
const char *sysfs_label
in the dev->msi and emitting that instead of computing it.
Jason
|