lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch V2 24/36] powerpc/pseries/msi: Use MSI device properties
    On Mon, Dec 06, 2021 at 11:39:34PM +0100, Thomas Gleixner wrote:
    > instead of fiddling with MSI descriptors.
    >
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
    > arch/powerpc/platforms/pseries/msi.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > +++ b/arch/powerpc/platforms/pseries/msi.c
    > @@ -447,9 +447,9 @@ static int rtas_prepare_msi_irqs(struct
    > static int pseries_msi_ops_prepare(struct irq_domain *domain, struct device *dev,
    > int nvec, msi_alloc_info_t *arg)
    > {
    > + bool is_msix = msi_device_has_property(dev, MSI_PROP_PCI_MSIX);
    > + int type = is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
    > struct pci_dev *pdev = to_pci_dev(dev);

    We have the pci_dev here, why not just do something like

    bool is_msix = pdev->msix_enabled;

    ?

    Jason

    \
     
     \ /
      Last update: 2021-12-08 16:53    [W:4.317 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site