Messages in this thread | | | Date | Wed, 8 Dec 2021 08:46:37 -0700 | Subject | Re: [PATCH] ipv6: fix NULL pointer dereference in ip6_output() | From | David Ahern <> |
| |
On 12/8/21 3:51 AM, Florian Westphal wrote: > David Ahern <dsahern@gmail.com> wrote: >> On 12/7/21 5:21 PM, Andrea Mayer wrote: >>> + IP6CB(skb)->iif = skb->skb_iif; >>> [...] >>> >>> What do you think? >>> >> >> I like that approach over the need for a fall back in core ipv6 code. > > What if the device is removed after ->iif assignment and before dev lookup? >
good point. SR6 should make sure the iif is not cleared, and the fallback to the skb->dev is still needed in case of delete.
| |