lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFCv3 4/7] HID: input: Make hidinput_find_field() static
    On Wed, Dec 1, 2021 at 5:43 PM Tero Kristo <tero.kristo@linux.intel.com> wrote:
    >
    > From: Mika Westerberg <mika.westerberg@linux.intel.com>
    >
    > This function is not called outside of hid-input.c so we can make it
    > static.
    >
    > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

    Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

    Cheers,
    Benjamin

    > ---
    > drivers/hid/hid-input.c | 4 ++--
    > include/linux/hid.h | 1 -
    > 2 files changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
    > index b428ee9b4d9b..f6332d269d49 100644
    > --- a/drivers/hid/hid-input.c
    > +++ b/drivers/hid/hid-input.c
    > @@ -1477,7 +1477,8 @@ void hidinput_report_event(struct hid_device *hid, struct hid_report *report)
    > }
    > EXPORT_SYMBOL_GPL(hidinput_report_event);
    >
    > -int hidinput_find_field(struct hid_device *hid, unsigned int type, unsigned int code, struct hid_field **field)
    > +static int hidinput_find_field(struct hid_device *hid, unsigned int type,
    > + unsigned int code, struct hid_field **field)
    > {
    > struct hid_report *report;
    > int i, j;
    > @@ -1492,7 +1493,6 @@ int hidinput_find_field(struct hid_device *hid, unsigned int type, unsigned int
    > }
    > return -1;
    > }
    > -EXPORT_SYMBOL_GPL(hidinput_find_field);
    >
    > struct hid_field *hidinput_get_led_field(struct hid_device *hid)
    > {
    > diff --git a/include/linux/hid.h b/include/linux/hid.h
    > index 96eaca0d5322..3f1fd4fcf1a9 100644
    > --- a/include/linux/hid.h
    > +++ b/include/linux/hid.h
    > @@ -636,7 +636,6 @@ extern void hidinput_disconnect(struct hid_device *);
    >
    > int hid_set_field(struct hid_field *, unsigned, __s32);
    > int hid_input_report(struct hid_device *, int type, u8 *, u32, int);
    > -int hidinput_find_field(struct hid_device *hid, unsigned int type, unsigned int code, struct hid_field **field);
    > struct hid_field *hidinput_get_led_field(struct hid_device *hid);
    > unsigned int hidinput_count_leds(struct hid_device *hid);
    > __s32 hidinput_calc_abs_res(const struct hid_field *field, __u16 code);
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2021-12-08 16:20    [W:8.108 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site