Messages in this thread | | | Subject | Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support | From | Alexandre TORGUE <> | Date | Wed, 8 Dec 2021 15:51:49 +0100 |
| |
On 12/8/21 3:22 PM, Marc Zyngier wrote: > Hi Alexandre, > > On Wed, 08 Dec 2021 13:58:46 +0000, > Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote: >> >>> Why does the driver need to carry these tables? This sort of >>> information should really come from DT, instead of being hardcoded in >>> the driver and bloating it for no reason. This all has a funny taste >>> of the board files we used to have pre-DT. >>> >> >> There are absolutely no reason to have it in driver. Honestly It has >> been done in this way to have minimal changes adding this new SoC >> support (and it's not smart, I agree). >> >> I think it is better to abandon this series. I will create a new one >> which moves mapping table for MP15 and adds MP13 support to. > > I'm afraid you'll have to keep the in-kernel table for MP15, since the > driver needs to work with old DTs. For new SoCs (such as MP13), moving > the table into DT would be good.
I can try to have both for MP15:use new mechanism as MP13 and keep the table inside the driver as a fallback if DT mapping is not provided (for old DT).
Thanks
> > Thanks, > > M. >
| |