lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] gpio:amdpt:add new device ID and 24-pin support
On Wed, Dec 08, 2021 at 06:36:21PM +0800, Yuchang Hsu wrote:

Thanks for update, my comments below.

> Hi Andy Shevchenko,

> How and what to put the Changelog after '---'?i just remove '---'.

No, you shouldn't remove it, instead you should add the text after it in a free
form of what you have done in the submitted version in comparison to the
previous one.

To achieve this use `git format-patch ...` and then edit it and then send it
with a help of `git send-email ...`.

> This patch adds a ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.

"This patch adds a ..." --> "Add an ..."

> And We retrieve pin number supporting by device_get_match_data().

"And " --> ""
"supporting " --> ""

So, waiting for v3.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-12-08 13:21    [W:0.098 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site