lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/5] iommu/mediatek: Remove the power status checking in tlb flush all
    Date
    From: Yong Wu <yong.wu@mediatek.com>

    To simplify the code, Remove the power status checking in the
    tlb_flush_all, remove this:
    if (pm_runtime_get_if_in_use(data->dev) <= 0)
    continue;

    The mtk_iommu_tlb_flush_all is called from
    a) isr
    b) tlb flush range fail case
    c) iommu_create_device_direct_mappings

    In first two cases, the power and clock are always enabled.
    In the third case tlb flush is unnecessary because in a later patch
    in the series a full flush from the pm_runtime_resume callback is added.

    In addition, writing the tlb control register when the iommu is not resumed
    is ok and the write is ignored.

    Signed-off-by: Yong Wu <yong.wu@mediatek.com>
    [refactor commit log]
    Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
    ---
    drivers/iommu/mtk_iommu.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
    index dd2c08c54df4..e30ac68fab48 100644
    --- a/drivers/iommu/mtk_iommu.c
    +++ b/drivers/iommu/mtk_iommu.c
    @@ -210,15 +210,10 @@ static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)

    static void mtk_iommu_tlb_flush_all(struct mtk_iommu_data *data)
    {
    - if (pm_runtime_get_if_in_use(data->dev) <= 0)
    - return;
    -
    writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
    data->base + data->plat_data->inv_sel_reg);
    writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
    wmb(); /* Make sure the tlb flush all done */
    -
    - pm_runtime_put(data->dev);
    }

    static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-12-08 13:09    [W:2.827 / U:1.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site