lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/3] perf tools: Support register names from all archs
From
Date
On 07/12/2021 18:06, German Gomez wrote:
> tools/perf/arch/arm/include/perf_regs.h | 42 --
> tools/perf/arch/arm64/include/perf_regs.h | 76 --
> tools/perf/arch/csky/include/perf_regs.h | 82 ---
> tools/perf/arch/mips/include/perf_regs.h | 69 --
> tools/perf/arch/powerpc/include/perf_regs.h | 66 --
> tools/perf/arch/riscv/include/perf_regs.h | 74 --
> tools/perf/arch/s390/include/perf_regs.h | 78 --
> tools/perf/arch/x86/include/perf_regs.h | 82 ---
> tools/perf/builtin-script.c | 18 +-
> tools/perf/util/perf_regs.c | 666 ++++++++++++++++++
> tools/perf/util/perf_regs.h | 10 +-
> .../scripting-engines/trace-event-python.c | 10 +-
> tools/perf/util/session.c | 25 +-
> 13 files changed, 697 insertions(+), 601 deletions(-)

Did you consider leaving the register structures where they are while
renaming to include the arch name and then having as externs or similar?
I see an example of that idea for arm64_unwind_libunwind_ops.

Cheers,
John

\
 
 \ /
  Last update: 2021-12-08 12:52    [W:0.092 / U:1.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site