lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v1 00/12] x86/mce: Correct the noinstr annotation
Date
From: Borislav Petkov <bp@suse.de>

Hi folks,

here's v1 with the instrumentation "sandwiching" documented, as
requested by peterz.

Tony, I'd appreciate making sure nothing in them breaks your injection
workflows before I queue them. And it shouldn't but... :-)

Thx.

Changelog:
==========

here's a first preliminary (it is based on some random 5.16-rc0 commit
and is tested only in qemu) of the series which correct all the noinstr
annotation of the #MC handler.

Since it calls a bunch of external facilities, the strategy is to mark
mce-specific functions called by the #MC handler as noinstr and when
they "call out" so to speak, to do a begin/end sandwich around that
call.

Please have a look and let me know if it looks ok-ish.

Further testing will happen after -rc1 releases, thus the "v0" version
here.

Thx.

Borislav Petkov (12):
x86/mce: Do not use memset to clear the banks bitmaps
x86/mce: Remove function-local cpus variables
x86/mce: Use mce_rdmsrl() in severity checking code
x86/mce: Remove noinstr annotation from mce_setup()
x86/mce: Allow instrumentation during task work queueing
x86/mce: Prevent severity computation from being instrumented
x86/mce: Mark mce_panic() noinstr
x86/mce: Mark mce_end() noinstr
x86/mce: Mark mce_read_aux() noinstr
x86/mce: Move the tainting outside of the noinstr region
x86/mce: Mark mce_timed_out() noinstr
x86/mce: Mark mce_start() noinstr

arch/x86/kernel/cpu/mce/core.c | 128 +++++++++++++++++++++--------
arch/x86/kernel/cpu/mce/internal.h | 2 +
arch/x86/kernel/cpu/mce/severity.c | 38 +++++----
3 files changed, 119 insertions(+), 49 deletions(-)

--
2.29.2

\
 
 \ /
  Last update: 2021-12-08 12:14    [W:0.100 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site