lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] KVM: X86: Handle implicit supervisor access with SMAP
From
On 12/7/21 22:52, Sean Christopherson wrote:
>> - unsigned long not_smap = (cpl - 3) & (rflags & X86_EFLAGS_AC);
>> + u32 not_smap = (rflags & X86_EFLAGS_AC) & vcpu->arch.explicit_access;
> I really, really dislike shoving this into vcpu->arch. I'd much prefer to make
> this a property of the access, even if that means adding another param or doing
> something gross with @access (@pfec here).
>

Well, we already have something gross going on with the pfec. Maybe we
should add separate constants for the index into mmu->permissions.

Paolo

\
 
 \ /
  Last update: 2021-12-08 10:13    [W:0.133 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site