Messages in this thread | | | Date | Tue, 7 Dec 2021 08:40:25 -0800 | From | Colin Foster <> | Subject | Re: [PATCH v4 net-next 5/5] net: mscc: ocelot: expose ocelot wm functions |
| |
On Tue, Dec 07, 2021 at 07:39:00AM -0800, Jakub Kicinski wrote: > On Tue, 7 Dec 2021 15:30:12 +0000 Vladimir Oltean wrote: > > On Tue, Dec 07, 2021 at 07:26:52AM -0800, Jakub Kicinski wrote: > > > On Tue, 7 Dec 2021 12:11:22 +0000 Vladimir Oltean wrote: > > > > I'm not taking this as a spiteful comment either, it is a very fair point. > > > > Colin had previously submitted this as part of a 23-patch series and it > > > > was me who suggested that this change could go in as part of preparation > > > > work right away: > > > > https://patchwork.kernel.org/project/netdevbpf/cover/20211116062328.1949151-1-colin.foster@in-advantage.com/#24596529 > > > > I didn't realize that in doing so with this particular change, we would > > > > end up having some symbols exported by the ocelot switch lib that aren't > > > > yet in use by other drivers. So yes, this would have to go in at the > > > > same time as the driver submission itself. > > > > > > I don't know the dependencies here (there are also pinctrl patches > > > in the linked series) so I'll defer to you, if there is a reason to > > > merge the unused symbols it needs to be spelled out, otherwise let's > > > drop the last patch for now. > > > > I don't think there's any problem with dropping the last patch for now, > > as that's the safer thing to do (Colin?), but just let us know whether > > you prefer Colin to resend a 4-patch series, or you can pick this series > > up without the last one. > > Repost once it's confirmed that's the right course of action. > I'll merge it right away.
I should be able to repost today without the last patch. It is an easy, and resonable one to drag along with the larger ocelot_spi patches I have in progress.
And I appreciate all the insight and feedback from everyone. Thanks for helping me keep keep me on track!
| |