lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
From
On 07/12/2021 16:54, Rob Herring wrote:
> On Tue, Dec 7, 2021 at 3:12 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> On 06/12/2021 18:42, Rob Herring wrote:
>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>>> has a warning:
>>>
>>> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>>>
>>> The child node definition for GPMC is not a complete binding, so specifying
>>> 'unevaluatedProperties: false' for it is not correct and should be
>>> dropped.
>>>
>>> Fixup the unnecessary 'allOf' while we're here.
>>>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Cc: Roger Quadros <rogerq@kernel.org>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
>>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>
>> Looks good. Rob, do you want to take it via your tree or I should handle it?
>
> I'll take it given there's also the somewhat related "dt-bindings:
> mtd: ti,gpmc-nand: Add missing 'rb-gpios'"

Sure, then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-12-07 17:28    [W:1.802 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site