Messages in this thread | | | Subject | Re: [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices | From | Jon Hunter <> | Date | Tue, 7 Dec 2021 15:07:17 +0000 |
| |
On 07/12/2021 11:57, Dmitry Osipenko wrote: > 07.12.2021 14:02, Jon Hunter пишет: >> >> On 07/12/2021 10:58, Dmitry Osipenko wrote: >>> 07.12.2021 13:44, Dmitry Osipenko пишет: >>>> 07.12.2021 13:22, Dmitry Osipenko пишет: >>>>> 07.12.2021 09:32, Sameer Pujar пишет: >>>>>> HDA regression is recently reported on Tegra194 based platforms. >>>>>> This happens because "hda2codec_2x" reset does not really exist >>>>>> in Tegra194 and it causes probe failure. All the HDA based audio >>>>>> tests fail at the moment. This underlying issue is exposed by >>>>>> commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP >>>>>> response") which now checks return code of BPMP command response. >>> >>> I see that this BPMP commit already has been reverted. There is no >>> problem in this hda_tegra driver at all. >> >> That is temporary until this fix is merged and then we will revert the >> revert. > > It's the device-tree that is broken, not the driver. If you don't care > about broken HDMI audio using outdated dtb, then there is nothing to fix > in the code.
That's correct. However, we do care about HDMI audio being broken with existing DTBs and so we need to make sure they still work.
Jon
-- nvpublic
| |