Messages in this thread | | | From | Hector Martin <> | Subject | [PATCH 0/2] mmc: sdhci-pci-gli: GL9755: Quirks for Apple ARM platforms | Date | Tue, 7 Dec 2021 15:40:17 +0900 |
| |
Hi folks,
This short series adds a few quirks needed to make the card readers in Apple M1 Pro/Max MacBook laptops work properly.
The first patch should be straightforward; it just allows configuring the CD/WP polarity based on device tree settings. There is already a standard DT binding for this.
The second patch bugs me. I don't understand why this problem happens on these machines, and not on e.g. x86 laptops (which presumably work with this driver). 8/16-bit MMIO reads work fine on other PCIe devices on these machines, so it is not a generalized problem with the PCIe controller in these SoCs. The problem also happens when running macOS (it also uses 32-bit reads). Ben, is there any chance you might know of some vendor-specific knob somewhere that can fix this issue without requiring the MMIO read workaround? Interestingly, 8/16-bit writes work perfectly fine.
Hector Martin (2): mmc: sdhci-pci-gli: GL9755: Support for CD/WP inversion on OF platforms mmc: sdhci-pci-gli: GL9755: Issue 8/16-bit MMIO reads as 32-bit reads.
drivers/mmc/host/sdhci-pci-gli.c | 38 ++++++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-)
-- 2.33.0
| |