Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 7 Dec 2021 14:00:40 +0100 | Subject | Re: [PATCH] powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough |
| |
On Tue, Dec 7, 2021 at 12:02 PM Anders Roxell <anders.roxell@linaro.org> wrote: > > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > Clang is more pedantic than GCC, which does not warn when failing > through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst. > Add athe missing break to silence the warning. > > Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Thanks for the fix!
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |