Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties | Date | Tue, 07 Dec 2021 13:47:37 +0100 |
| |
On Tue, Dec 07 2021 at 10:04, Cédric Le Goater wrote: >> +/** >> + * msi_device_set_properties - Set device specific MSI properties >> + * @dev: Pointer to the device which is queried >> + * @prop: Properties to set >> + */ >> +void msi_device_set_properties(struct device *dev, unsigned long prop) >> +{ >> + if (WARN_ON_ONCE(!dev->msi.data)) >> + return ; >> + dev->msi.data->properties = 0; > It would work better if the prop variable was used instead of 0. > > With that fixed,
Indeed. Copy & pasta w/o brain usage ...
| |