Messages in this thread | | | Subject | Re: [PATCH] media: c8sectpfe: remove redundant assignment to pointer tsin | From | Patrice CHOTARD <> | Date | Tue, 7 Dec 2021 10:35:01 +0100 |
| |
Hi Colin
On 12/5/21 1:37 AM, Colin Ian King wrote: > Pointer tsin is being assigned a value that is never read. The assignment > is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c > index 02dc78bd7fab..e1f520903248 100644 > --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c > +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c > @@ -930,12 +930,8 @@ static int configure_channels(struct c8sectpfei *fei) > > /* iterate round each tsin and configure memdma descriptor and IB hw */ > for_each_child_of_node(np, child) { > - > - tsin = fei->channel_data[index]; > - > ret = configure_memdma_and_inputblock(fei, > fei->channel_data[index]); > - > if (ret) { > dev_err(fei->dev, > "configure_memdma_and_inputblock failed\n"); >
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks Patrice
| |