lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: c8sectpfe: remove redundant assignment to pointer tsin
From
Date
Hi Colin

On 12/5/21 1:37 AM, Colin Ian King wrote:
> Pointer tsin is being assigned a value that is never read. The assignment
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 02dc78bd7fab..e1f520903248 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -930,12 +930,8 @@ static int configure_channels(struct c8sectpfei *fei)
>
> /* iterate round each tsin and configure memdma descriptor and IB hw */
> for_each_child_of_node(np, child) {
> -
> - tsin = fei->channel_data[index];
> -
> ret = configure_memdma_and_inputblock(fei,
> fei->channel_data[index]);
> -
> if (ret) {
> dev_err(fei->dev,
> "configure_memdma_and_inputblock failed\n");
>

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice

\
 
 \ /
  Last update: 2021-12-07 10:36    [W:0.118 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site