lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next v4 2/2] net: ethernet: Add driver for Sunplus SP7021
Date
Hi Jakub,

Thank you for review.

I'll fix the warnings reported from clang next patch.


Best regards,
Wells Lu


> On Tue, 7 Dec 2021 16:06:59 +0800 Wells Lu wrote:
> > Add driver for Sunplus SP7021 SoC.
> >
> > Signed-off-by: Wells Lu <wellslutw@gmail.com>
>
> clang points out:
>
> drivers/net/ethernet/sunplus/spl2sw_driver.c:223:65: warning: result of comparison of
> constant 188 with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
> (mac_addr[0] != 0xFC || mac_addr[1] != 0x4B || mac_addr[2] != 0xBC)) {
> ~~~~~~~~~~~ ^ ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:223:19: warning: result of comparison of
> constant 252 with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
> (mac_addr[0] != 0xFC || mac_addr[1] != 0x4B || mac_addr[2] != 0xBC)) {
> ~~~~~~~~~~~ ^ ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:222:64: warning: result of comparison of
> constant 188 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (mac_addr[5] == 0xFC && mac_addr[4] == 0x4B && mac_addr[3] == 0xBC &&
> ~~~~~~~~~~~ ^ ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:222:18: warning: result of comparison of
> constant 252 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (mac_addr[5] == 0xFC && mac_addr[4] == 0x4B && mac_addr[3] == 0xBC &&
> ~~~~~~~~~~~ ^ ~~~~
\
 
 \ /
  Last update: 2021-12-08 05:38    [W:0.086 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site