Messages in this thread | | | From | "Vaittinen, Matti" <> | Subject | Re: [PATCH v2 1/3] gpio: Get rid of duplicate of_node assignment in the drivers | Date | Tue, 7 Dec 2021 05:32:46 +0000 |
| |
On 12/6/21 15:18, Andy Shevchenko wrote: > GPIO library does copy the of_node from the parent device of > the GPIO chip, there is no need to repeat this in the individual > drivers. Remove these assignment all at once. > > For the details one may look into the of_gpio_dev_init() implementation. > > While at it, remove duplicate parent device assignment where it is the case. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: mentioned parent removal (Linus), dropped change of the removed code > drivers/gpio/gpio-adnp.c | 1 - > drivers/gpio/gpio-amdpt.c | 4 +--- > drivers/gpio/gpio-bd71828.c | 1 -
for bd71828: Reviewed-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
-- The Linux Kernel guy at ROHM Semiconductors
Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND
~~ this year is the year of a signature writers block ~~
| |