Messages in this thread Patch in this message | | | From | Lai Jiangshan <> | Subject | [PATCH 3/7] workqueue: Remove outdated comment about exceptional workers in unbind_workers() | Date | Tue, 7 Dec 2021 15:35:39 +0800 |
| |
From: Lai Jiangshan <laijs@linux.alibaba.com>
Long time before, workers are not ALL bound after CPU_ONLINE, they can still be running in other CPUs before self rebinding.
But the commit a9ab775bcadf ("workqueue: directly restore CPU affinity of workers from CPU_ONLINE") makes rebind_workers() bind them all.
So all workers are on the CPU before the CPU is down.
And the comment in unbind_workers() refers to the workers "which are still executing works from before the last CPU down" is outdated. Just removed it.
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com> --- kernel/workqueue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ba8cf5f5e7fa..ad663853bb78 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -4998,9 +4998,7 @@ static void unbind_workers(int cpu) /* * We've blocked all attach/detach operations. Make all workers * unbound and set DISASSOCIATED. Before this, all workers - * except for the ones which are still executing works from - * before the last CPU down must be on the cpu. After - * this, they may become diasporas. + * must be on the cpu. After this, they may become diasporas. */ for_each_pool_worker(worker, pool) worker->flags |= WORKER_UNBOUND; -- 2.19.1.6.gb485710b
| |