lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 11/11] i2c: nvidia-gpu: Convert to use dev_err_probe()
    Date
    It's fine to call dev_err_probe() in ->probe() when error code is known.
    Convert the driver to use dev_err_probe().

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/i2c/busses/i2c-nvidia-gpu.c | 18 ++++++------------
    1 file changed, 6 insertions(+), 12 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
    index a82be377146e..6920c1b9a126 100644
    --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
    +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
    @@ -282,24 +282,18 @@ static int gpu_i2c_probe(struct pci_dev *pdev, const struct pci_device_id *id)
    dev_set_drvdata(dev, i2cd);

    status = pcim_enable_device(pdev);
    - if (status < 0) {
    - dev_err(dev, "pcim_enable_device failed %d\n", status);
    - return status;
    - }
    + if (status < 0)
    + return dev_err_probe(dev, status, "pcim_enable_device failed\n");

    pci_set_master(pdev);

    i2cd->regs = pcim_iomap(pdev, 0, 0);
    - if (!i2cd->regs) {
    - dev_err(dev, "pcim_iomap failed\n");
    - return -ENOMEM;
    - }
    + if (!i2cd->regs)
    + return dev_err_probe(dev, -ENOMEM, "pcim_iomap failed\n");

    status = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI);
    - if (status < 0) {
    - dev_err(dev, "pci_alloc_irq_vectors err %d\n", status);
    - return status;
    - }
    + if (status < 0)
    + return dev_err_probe(dev, status, "pci_alloc_irq_vectors err\n");

    gpu_enable_i2c_bus(i2cd);

    --
    2.33.0
    \
     
     \ /
      Last update: 2021-12-07 20:23    [W:3.137 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site