lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [net-next RFC PATCH 0/6] Add support for qca8k mdio rw in Ethernet packet
    > I still have to find a solution to a slowdown problem and this is where
    > I would love to get some hint.
    > Currently I still didn't find a good way to understand when the tagger
    > starts to accept packets and because of this the initial setup is slow
    > as every completion timeouts. Am I missing something or is there a way
    > to check for this?

    I've not looked at this particular driver, i just know the general
    architecture.

    The MDIO bus driver probes first, maybe as part of the Ethernet
    driver, maybe as a standalone MDIO driver. The switch is found in DT
    and the driver code will at some point later probe the switch driver.

    The switch driver has working MDIO at this point. It should use MDIO
    to talk to the switch, make sure it is there, maybe do some initial
    configuration. Once it is happy, it registers the switch with the DSA
    core using dsa_register_switch().

    If this is a single switch, the DSA core will then start setting
    things up. As part of dsa_switch_setup() it will call the switch
    drivers setup() method. It then figures out what tag driver to use, by
    calling dsa_switch_setup_tag_protocol(). However, the tag driver
    itself is not inserted into the chain yet. That happens later. Once
    the switch is setup, dsa_tree_setup_master() is called which does
    dsa_master_setup() and in the middle there is:

    /* If we use a tagging format that doesn't have an ethertype
    * field, make sure that all packets from this point on get
    * sent to the tag format's receive function.
    */
    wmb();

    dev->dsa_ptr = cpu_dp;

    This is the magic to actually enable the tagger receiving frames.

    I need to look at your patches, but why is the tagger involved? At
    least for the Marvell switch, you send a pretty normal looking
    Ethernet frame to a specific MAC address, and the switch replies using
    that MAC address. And it has an Ether Type specific to switch
    control. Since this is all normal looking, there are hooks in the
    network stack which can be used to get these frames.

    Andrew

    \
     
     \ /
      Last update: 2021-12-07 19:42    [W:4.690 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site