lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 012/207] ALSA: usb-audio: Dont start stream for capture at prepare
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 83de8f83816e8e15227dac985163e3d433a2bf9d upstream.

    The recent change made mistakenly the stream for capture started at
    prepare stage. Add the stream direction check to avoid it.

    Fixes: 9c9a3b9da891 ("ALSA: usb-audio: Rename early_playback_start flag with lowlatency_playback")
    Link: https://lore.kernel.org/r/20211119102629.7476-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/usb/pcm.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/sound/usb/pcm.c
    +++ b/sound/usb/pcm.c
    @@ -640,7 +640,8 @@ static int snd_usb_pcm_prepare(struct sn
    runtime->delay = 0;

    subs->lowlatency_playback = lowlatency_playback_available(runtime, subs);
    - if (!subs->lowlatency_playback)
    + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK &&
    + !subs->lowlatency_playback)
    ret = start_endpoints(subs);

    unlock:

    \
     
     \ /
      Last update: 2021-12-06 16:40    [W:3.537 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site