Messages in this thread | | | Date | Mon, 6 Dec 2021 13:16:04 +0100 | Subject | Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema | From | Michal Simek <> |
| |
Hi,
On 12/2/21 16:53, Rob Herring wrote: > On Thu, Dec 2, 2021 at 4:10 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> >> Hi Rob, >> >> CC Michal >> >> On Thu, Dec 2, 2021 at 12:25 AM Rob Herring <robh@kernel.org> wrote: >>> On Fri, Nov 26, 2021 at 12:57:00PM +0100, Geert Uytterhoeven wrote: >>>> Convert the Cadence MACB/GEM Ethernet controller Device Tree binding >>>> documentation to json-schema. >>>> >>>> Re-add "cdns,gem" (removed in commit a217d8711da5c87f ("dt-bindings: >>>> Remove PicoXcell bindings")) as there are active users on non-PicoXcell >>>> platforms. >>>> Add missing "ether_clk" clock. >>>> Add missing properties. >>>> >>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml >> >>>> + '#stream-id-cells': >>>> + const: 1 >>> >>> I can't figure out why you have this here. I'll drop it while applying. >> >> See arch/arm64/boot/dts/xilinx/zynqmp.dtsi and >> drivers/iommu/arm/arm-smmu/arm-smmu.c. >> >> It wasn't clear to me if this is still needed, or legacy. Michal? > > They should update to the iommu binding instead of the legacy smmu > one. It's been around for years now.
At the beginning it was there for XEN usage which was using this legacy binding. Stefano: Please confirm that it is not needed anymore that we can remove it for zynqmp and versal.
Thanks, Michal
| |