Messages in this thread | | | Date | Mon, 6 Dec 2021 11:48:23 +0100 | From | Joerg Roedel <> | Subject | Re: [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API |
| |
On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote: > Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> > Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com> > Signed-off-by: Ashok Raj <ashok.raj@intel.com> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > Signed-off-by: Eric Auger <eric.auger@redhat.com>
This Signed-of-by chain looks dubious, you are the author but the last one in the chain?
> +int iommu_uapi_attach_pasid_table(struct iommu_domain *domain, > + void __user *uinfo) > +{
[...]
> + if (pasid_table_data.format == IOMMU_PASID_FORMAT_SMMUV3 && > + pasid_table_data.argsz < > + offsetofend(struct iommu_pasid_table_config, vendor_data.smmuv3)) > + return -EINVAL;
This check looks like it belongs in driver specific code.
Regards,
Joerg
| |