Messages in this thread Patch in this message | | | From | Baolin Wang <> | Date | Tue, 7 Dec 2021 09:39:24 +0800 | Subject | Re: [PATCH] dmaengine: sprd: move pm_runtime_disable to err_rpm |
| |
Hi Dongliang,
On Mon, Dec 6, 2021 at 7:34 PM Dongliang Mu <mudongliangabcd@gmail.com> wrote: > > When pm_runtime_get_sync fails, it forgets to invoke pm_runtime_disable > in the label err_rpm. > > Fix this by moving pm_runtime_disable to label err_rpm. > > Fixes: 9b3b8171f7f4 ("dmaengine: sprd: Add Spreadtrum DMA driver") > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> > ---
Thanks for your patch, but looking at the code in detail, I think we also should decrease the rpm counter when failing to call the pm_runtime_get_sync().
--- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1210,7 +1210,7 @@ static int sprd_dma_probe(struct platform_device *pdev) ret = dma_async_device_register(&sdev->dma_dev); if (ret < 0) { dev_err(&pdev->dev, "register dma device failed:%d\n", ret); - goto err_register; + goto err_rpm; }
sprd_dma_info.dma_cap = sdev->dma_dev.cap_mask; @@ -1224,10 +1224,9 @@ static int sprd_dma_probe(struct platform_device *pdev)
err_of_register: dma_async_device_unregister(&sdev->dma_dev); -err_register: +err_rpm: pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); -err_rpm: sprd_dma_disable(sdev); return ret; } -- Baolin Wang
| |