lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: venus: helpers: Fix memory leak in venus_helper_alloc_dpb_bufs
From
Date
Hi José

Quoting José Expósito (2021-12-05 19:04:15)
> Addresses-Coverity-ID: 1494120 ("Resource leaks")

This was also recently posted by Ameer in https://lore.kernel.org/all/20211204205504.6550-1-amhamza.mgc@gmail.com/

Regards
--
Kieran

> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 84c3a511ec31..344a42853898 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -197,6 +197,7 @@ int venus_helper_alloc_dpb_bufs(struct venus_inst *inst)
>
> id = ida_alloc_min(&inst->dpb_ids, VB2_MAX_FRAME, GFP_KERNEL);
> if (id < 0) {
> + kfree(buf);
> ret = id;
> goto fail;
> }
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2021-12-06 10:50    [W:3.295 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site