lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 176/207] preempt/dynamic: Fix setup_preempt_mode() return value
    Date
    From: Andrew Halaney <ahalaney@redhat.com>

    [ Upstream commit 9ed20bafc85806ca6c97c9128cec46c3ef80ae86 ]

    __setup() callbacks expect 1 for success and 0 for failure. Correct the
    usage here to reflect that.

    Fixes: 826bfeb37bb4 ("preempt/dynamic: Support dynamic preempt with preempt= boot option")
    Reported-by: Mark Rutland <mark.rutland@arm.com>
    Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/20211203233203.133581-1-ahalaney@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/sched/core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    index 6f4625f8276f1..4170ec15926ee 100644
    --- a/kernel/sched/core.c
    +++ b/kernel/sched/core.c
    @@ -6660,11 +6660,11 @@ static int __init setup_preempt_mode(char *str)
    int mode = sched_dynamic_mode(str);
    if (mode < 0) {
    pr_warn("Dynamic Preempt: unsupported mode: %s\n", str);
    - return 1;
    + return 0;
    }

    sched_dynamic_update(mode);
    - return 0;
    + return 1;
    }
    __setup("preempt=", setup_preempt_mode);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-12-06 17:11    [W:4.224 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site