lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 166/207] net/mlx5: E-Switch, Check group pointer before reading bw_share value
    Date
    From: Dmytro Linkin <dlinkin@nvidia.com>

    [ Upstream commit 5c4e8ae7aa4875041102406801ee434e6c581aef ]

    If log_esw_max_sched_depth is not supported group pointer of the vport
    is NULL. Hence, check the pointer before reading bw_share value.

    Fixes: 0fe132eac38c ("net/mlx5: E-switch, Allow to add vports to rate groups")
    Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
    Reviewed-by: Roi Dayan <roid@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c
    index 4501e3d737f80..d377ddc70fc70 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c
    @@ -130,7 +130,7 @@ static u32 esw_qos_calculate_min_rate_divider(struct mlx5_eswitch *esw,
    /* If vports min rate divider is 0 but their group has bw_share configured, then
    * need to set bw_share for vports to minimal value.
    */
    - if (!group_level && !max_guarantee && group->bw_share)
    + if (!group_level && !max_guarantee && group && group->bw_share)
    return 1;
    return 0;
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-12-06 17:11    [W:4.140 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site