lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 031/207] thermal: core: Reset previous low and high trip during thermal zone init
    Date
    From: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>

    [ Upstream commit 99b63316c39988039965693f5f43d8b4ccb1c86c ]

    During the suspend is in process, thermal_zone_device_update bails out
    thermal zone re-evaluation for any sensor trip violation without
    setting next valid trip to that sensor. It assumes during resume
    it will re-evaluate same thermal zone and update trip. But when it is
    in suspend temperature goes down and on resume path while updating
    thermal zone if temperature is less than previously violated trip,
    thermal zone set trip function evaluates the same previous high and
    previous low trip as new high and low trip. Since there is no change
    in high/low trip, it bails out from thermal zone set trip API without
    setting any trip. It leads to a case where sensor high trip or low
    trip is disabled forever even though thermal zone has a valid high
    or low trip.

    During thermal zone device init, reset thermal zone previous high
    and low trip. It resolves above mentioned scenario.

    Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
    Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/thermal_core.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
    index 30134f49b037a..13891745a9719 100644
    --- a/drivers/thermal/thermal_core.c
    +++ b/drivers/thermal/thermal_core.c
    @@ -419,6 +419,8 @@ static void thermal_zone_device_init(struct thermal_zone_device *tz)
    {
    struct thermal_instance *pos;
    tz->temperature = THERMAL_TEMP_INVALID;
    + tz->prev_low_trip = -INT_MAX;
    + tz->prev_high_trip = INT_MAX;
    list_for_each_entry(pos, &tz->thermal_instances, tz_node)
    pos->initialized = false;
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-12-06 17:11    [W:7.511 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site