lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 047/130] tracing/histograms: String compares should not care about signed values
    Date
    From: Steven Rostedt (VMware) <rostedt@goodmis.org>

    commit 450fec13d9170127678f991698ac1a5b05c02e2f upstream.

    When comparing two strings for the "onmatch" histogram trigger, fields
    that are strings use string comparisons, which do not care about being
    signed or not.

    Do not fail to match two string fields if one is unsigned char array and
    the other is a signed char array.

    Link: https://lore.kernel.org/all/20211129123043.5cfd687a@gandalf.local.home/

    Cc: stable@vgerk.kernel.org
    Cc: Tom Zanussi <zanussi@kernel.org>
    Cc: Yafang Shao <laoar.shao@gmail.com>
    Fixes: b05e89ae7cf3b ("tracing: Accept different type for synthetic event fields")
    Reviewed-by: Masami Hiramatsu <mhiramatsu@kernel.org>
    Reported-by: Sven Schnelle <svens@linux.ibm.com>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/trace/trace_events_hist.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/trace/trace_events_hist.c
    +++ b/kernel/trace/trace_events_hist.c
    @@ -3344,7 +3344,7 @@ static int check_synth_field(struct synt

    if (strcmp(field->type, hist_field->type) != 0) {
    if (field->size != hist_field->size ||
    - field->is_signed != hist_field->is_signed)
    + (!field->is_string && field->is_signed != hist_field->is_signed))
    return -EINVAL;
    }


    \
     
     \ /
      Last update: 2021-12-06 17:10    [W:4.118 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site