Messages in this thread | | | Date | Mon, 6 Dec 2021 21:27:48 +0530 | Subject | Re: [PATCHv5 1/4] arm64: io: Use asm-generic high level MMIO accessors | From | Sai Prakash Ranjan <> |
| |
On 12/6/2021 8:45 PM, Arnd Bergmann wrote: > On Mon, Dec 6, 2021 at 2:52 PM Sai Prakash Ranjan > <quic_saipraka@quicinc.com> wrote: >> Sorry, what I meant was the literal name of these macros, i.e., >> __iormb() has more explicit naming as >> IO read memory barrier and __io_ar() is IO after read? So doesn't it >> make more sense that __iormb() >> should be the primary definition which is already the case and ar/bw >> should be based on them. > My reasoning was that we should ideally only have one set, and that > __io_ar()/__io_bw() are the ones used in architecture-independent code, > so I'd rather use those and deprecate the arm64 specific ones, eventually > moving all the arm64 specific code to use those directly where needed. > > Arnd
Ah ok, good enough. I will do this in the next version.
Thanks, Sai
| |