Messages in this thread | | | Subject | Re: [PATCH v3 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use | From | Amjad Ouled-Ameur <> | Date | Sun, 5 Dec 2021 22:35:20 +0100 |
| |
Hi Martin,
Thank you for reviewing this.
On 21/11/2021 00:57, Martin Blumenstingl wrote: > Hi Amjad, > > Thanks for working on this! > > On Fri, Nov 12, 2021 at 5:33 PM Amjad Ouled-Ameur > <aouledameur@baylibre.com> wrote: > [...] >> + reset_control_rearm(priv->reset); > Using priv->reset in this driver currently requires an IS_ERR check beforehand. > When I wrote the driver originally I used the following code in > phy_meson8b_usb2_probe: > priv->reset = ... > if (PTR_ERR(priv->reset) == -EPROBE_DEFER) > return PTR_ERR(priv->reset); > > That means: priv->reset can (in theory) be an error pointer at runtime. > Since your patch is valid: can you please add another one (before this > one) in the series and change the priv->reset error checking to use > something like: > if (IS_ERR(priv->reset)) > return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset), "Failed to > get the reset line");
No worries, will do.
Regards,
Amjad
> With such a patch you can consider this one as: > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > > Best regards, > Martin
| |