Messages in this thread | | | From | "Song Bao Hua (Barry Song)" <> | Subject | RE: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes | Date | Sat, 4 Dec 2021 09:07:12 +0000 |
| |
> -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > Sent: Friday, December 3, 2021 3:27 AM > To: Heiko Carstens <hca@linux.ibm.com> > Cc: Peter Zijlstra <peterz@infradead.org>; Rafael J . Wysocki > <rafael@kernel.org>; Andrew Morton <akpm@linux-foundation.org>; > linux-kernel@vger.kernel.org; Jonathan Cameron <jonathan.cameron@huawei.com>; > Len Brown <len.brown@intel.com>; Thomas Richter <tmricht@linux.ibm.com>; Ian > Rogers <irogers@google.com> > Subject: Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes > > On Thu, Dec 02, 2021 at 03:22:05PM +0100, Heiko Carstens wrote: > > On Mon, Nov 29, 2021 at 03:03:18PM +0100, Peter Zijlstra wrote: > > > On Mon, Nov 29, 2021 at 02:03:06PM +0100, Heiko Carstens wrote: > > > > v2: > > > > As requested by Greg KH: avoid negative logic and use uppercase defines. > > > > > > > > v1: > > > > Create die and cluster cpu topology sysfs attributes only if an > > > > architecture makes uses of it, instead of creating them always for all > > > > architectures with bogus default values. > > > > Also change the book and drawer cpu topology macros so they match all > > > > all other topology macros. > > > > > > > > v1: > https://lore.kernel.org/lkml/20211128212221.1069726-1-hca@linux.ibm.com/ > > > > > > > > Heiko Carstens (3): > > > > topology/sysfs: export die attributes only if an architectures has > support > > > > topology/sysfs: export cluster attributes only if an architectures has > support > > > > topology/sysfs: rework book and drawer topology ifdefery > > > > > > > > Documentation/admin-guide/cputopology.rst | 33 +++++++++++------------ > > > > drivers/base/topology.c | 28 ++++++++++++++----- > > > > include/linux/topology.h | 25 +++++++++++++++++ > > > > 3 files changed, 62 insertions(+), 24 deletions(-) > > > > > > Seems entirely reasonable to me, > > > > > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > > > Since there seem to be no objections, who should pick this up? > > I'd assume the s390 tree would not be appropriate. > > > > Andrew, Greg, Peter? > > I will take it, thanks.
Could you give me one minute?
+Brice
I'd like to hear some feedbacks from hwloc if there is a chance to break userspace and if userspace depends on the existence of sysfs even though the topology doesn't exist.
If no, I feel it is safe to take.
> > greg k-h
Thanks Barry
| |