Messages in this thread | | | Date | Sat, 4 Dec 2021 11:27:43 +0300 | Subject | Re: [PATCH] staging: vt6655: refactor byMinChannel to min_channel | From | Pavel Skripkin <> |
| |
On 12/4/21 03:40, Alberto Merciai wrote: > Replace camelcase hungarian notated variable "byMinChannel" > into linux kernel coding style equivalent variable "min_channel". > > Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com> > --- > drivers/staging/vt6655/device.h | 2 +- > drivers/staging/vt6655/device_main.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h > index 6ea4165e4929..109d20a010ab 100644 > --- a/drivers/staging/vt6655/device.h > +++ b/drivers/staging/vt6655/device.h > @@ -200,7 +200,7 @@ struct vnt_private { > unsigned char byTopOFDMBasicRate; > unsigned char byTopCCKBasicRate; > > - unsigned char byMinChannel; > + unsigned char min_channel; > unsigned char max_channel; > > unsigned char preamble_type; > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c > index 313f0241d989..4d92b5df5312 100644 > --- a/drivers/staging/vt6655/device_main.c > +++ b/drivers/staging/vt6655/device_main.c > @@ -228,7 +228,7 @@ static void device_init_registers(struct vnt_private *priv) > spin_unlock_irqrestore(&priv->lock, flags); > > /* Get Channel range */ > - priv->byMinChannel = 1; > + priv->min_channel = 1; > priv->max_channel = CB_MAX_CHANNEL; > > /* Get Antena */ >
Looks like this variable is set, but never used. Shouldn't it be just removed?
Same for max_channel (or byMaxChannel).
With regards, Pavel Skripkin
| |