Messages in this thread | | | Date | Sat, 4 Dec 2021 12:57:32 -0800 | Subject | Re: [PATCH v2 3/3] mmc: Add driver for LiteX's LiteSDCard interface | From | Randy Dunlap <> |
| |
Hi Gabriel--
On 12/4/21 12:41, Gabriel Somlo wrote: > +MODULE_DESCRIPTION("LiteX SDCard driver"); > +MODULE_AUTHOR("Antmicro <www.antmicro.com>");
Admittedly it's not documented, but we would prefer to have some contact info in MODULE_AUTHOR(), like an email address or a person's name.
<linux/module.h> says:
/* * Author(s), use "Name <email>" or just "Name", for multiple * authors use multiple MODULE_AUTHOR() statements/lines. */ #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
> +MODULE_LICENSE("GPL v2");
Also, it's up to the MMC maintainer (Ulf), but the function signature style that is used in this driver is not the preferred style.
E.g.:
+static int +litex_set_bus_width(struct litex_mmc_host *host) +{
should be
+static int litex_set_bus_width(struct litex_mmc_host *host) +{
thanks. -- ~Randy
| |